bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 2070 in lilypond: Patch: Don't wrap EventChord around rhythmic


From: lilypond
Subject: Re: Issue 2070 in lilypond: Patch: Don't wrap EventChord around rhythmic events by default.
Date: Sat, 10 Dec 2011 11:11:33 +0000


Comment #10 on issue 2070 by address@hidden: Patch: Don't wrap EventChord around rhythmic events by default.
http://code.google.com/p/lilypond/issues/detail?id=2070

The appearance in tablature-harmonic-functions.ly is simply wrong (all of them are too high even before the change) because there are string numbers underneath that have been made transparent, see issue 2085, and there is one additional non-chord event for which a "transparent" string number messes up the spacing like it already happens with the chord event string numbers.

The actual change here is that string numbers on single notes don't just disappear, and the suspicious move you observe is a transparent string number. This difference gets much more obvious when you do -dno-event-chord-wrapper, but there are some more differences that bypass the event chord wrapper, like when you explicitly call make-sequential-music yourself instead of using { ... } or #{ ... #}.

This is what happens in the function creating harmonics. Also some grace functions are affected. I'll be changing most of those since they mostly are cases of unnecessary complex or imprudent programming, but of course this does not help users that have written similar constructs in their code.

I won't be pushing this patch before getting considerably useful feedback from some of the more heavy hitters regarding their private document base.

See also issue 2085 for more problems triggered by this patch (depending on whether you use -dno-event-chord-wrapper or not). There is not really much of a shortage for them.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]