|
From: | lilypond |
Subject: | Re: Issue 2356 in lilypond: Lilypond segfaults |
Date: | Sat, 03 Mar 2012 21:16:36 +0000 |
Comment #33 on issue 2356 by address@hidden: Lilypond segfaults http://code.google.com/p/lilypond/issues/detail?id=2356 Ok Mike, I was trying to change this. It starts out withGrob *vertical_alignment = Grob::get_root_vertical_alignment ((*axis_groups_.begin ()).first); if (!vertical_alignment) // we are at the beginning of a score, so no need for stubs
return;axis_groups_ is a _map_. You take an _arbitrary_ element of the map (whatever happens to have the first hash bucket), then call get_root_vertical_alignment on it and work on the elements. And you never clear out the map.
This is garbage. Total garbage. Please get a night of sleep and then write down what this engraver is supposed to be doing. Not how, _what_. It is part of a very large commit. If we can't figure out what this is for and how it is related to the rest, the whole commit will need to get reverted and rewritten, and there is likely quite a bit depending on it.
[Prev in Thread] | Current Thread | [Next in Thread] |