bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PATCH: stack overflow on large dependency set


From: Wil Evers
Subject: Re: PATCH: stack overflow on large dependency set
Date: Wed, 09 Oct 2002 17:01:14 +0200

Hi,

Paul D. Smith wrote:
 
> I don't think I'll use this exact patch, since putting 0x30000 chars on
> the stack doesn't seem like a good idea... plus the chance that a rule
> needs 0x10000 chars for its prerequisites list seems very small to me.

Well, the exact amount allocated on the stack is easily configurable by
the three #defines I added to the top of the file.  The idea is not to
use the heap if we don't have to.

> But I'll do something so that this function doesn't use alloca() and
> fail with large prerequisite lists.

The ability to have a file depend on a lot of other files may be
important to some; all I can say is I'm sure it's important to me.

Thanks,

- Wil




reply via email to

[Prev in Thread] Current Thread [Next in Thread]