[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fix for make gaining jobserver tokens
From: |
Paul Smith |
Subject: |
Re: fix for make gaining jobserver tokens |
Date: |
Sun, 13 Nov 2011 19:19:16 -0500 |
On Tue, 2011-10-25 at 13:34 -0700, Tim Newsome wrote:
> We do a lot of builds (as in double-digit servers building non-stop).
> Sometimes, when a part of the build fails, make -j8 would die with:
> make: INTERNAL: Exiting with 9 jobserver tokens available; should be
> 8
>
> With -j16 the error would be 17 instead of 16, etc. I think it's
> simply an off-by-one error in cleanup code that is almost never run.
> Attached is a patch that fixes it. We've been running with it for over
> 5 days now and haven't noticed any problems.
I applied a change to fix this. I tried for a while but couldn't
generate a repro case. Bummer.
Thanks!
--
-------------------------------------------------------------------------------
Paul D. Smith <address@hidden> Find some GNU make tips at:
http://www.gnu.org http://make.mad-scientist.net
"Please remain calm...I may be mad, but I am a professional." --Mad Scientist
- Re: fix for make gaining jobserver tokens,
Paul Smith <=