bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #35410] [patch] Fix a bug with filter/filter-out functions when pat


From: Eldar Abusalimov
Subject: [bug #35410] [patch] Fix a bug with filter/filter-out functions when pattern contains only quoted percents
Date: Mon, 30 Jan 2012 23:41:09 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.1 (KHTML, like Gecko) Ubuntu/11.04 Chromium/14.0.835.202 Chrome/14.0.835.202 Safari/535.1

URL:
  <http://savannah.gnu.org/bugs/?35410>

                 Summary: [patch] Fix a bug with filter/filter-out functions
when pattern contains only quoted percents
                 Project: make
            Submitted by: abusalimov
            Submitted on: Mon 30 Jan 2012 11:41:08 PM GMT
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
       Component Version: CVS
        Operating System: Any
           Fixed Release: None
           Triage Status: None

    _______________________________________________________

Details:

Literal pattern containing quoted percents (without any operative ones) does
not match any word.


# Expected to return 'foo%bar', but returns nothing.
$(filter foo\%bar,foo%bar)


This happens because after calling 'find_percent' function the string length
can decrease, but pattern matching code for literals uses old value of the
length.

The attached patch also removes a code used to restore whitespaces inside the
first argument as far as arguments are always get freed after calling a
function handler anyway.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 30 Jan 2012 11:41:08 PM GMT  Name: func_filter.patch  Size: 991B  
By: abusalimov
patch against CVS HEAD
<http://savannah.gnu.org/bugs/download.php?file_id=24928>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?35410>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]