[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug #39158] Cppcheck report
|
From: |
anonymous |
|
Subject: |
[bug #39158] Cppcheck report |
|
Date: |
Wed, 05 Jun 2013 18:33:21 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20100101 Firefox/10.0.12 Iceweasel/10.0.12 |
Follow-up Comment #2, bug #39158 (project make):
These may interest you in particular:
[signame.c:247]: (warning) Logical disjunction always evaluates to true: sig >
0 || sig < 32.
247 if (sig > 0 || sig < NSIG)
248 return (char *) sys_siglist[sig];
Indeed, I think it should be:
247 if (sig > 0 && sig < NSIG)
248 return (char *) sys_siglist[sig];
[remake.c:1402] -> [remake.c:1402]: (style) Same expression on both sides of
'&&'.
1402 if (mtime != NONEXISTENT_MTIME && file->command_state ==
cs_not_started
1403 && file->command_state == cs_not_started
1404 && !file->tried_implicit && file->intermediate)
There's one "file->command_state == cs_not_started" which could be removed but
should it be replaced by something else?
Julien
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?39158>
_______________________________________________
Message posté via/par Savannah
http://savannah.gnu.org/