[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #52076] wildcard/glob should be sorted

From: Ximin Luo
Subject: [bug #52076] wildcard/glob should be sorted
Date: Wed, 18 Oct 2017 15:25:11 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0

Follow-up Comment #15, bug #52076 (project make):

Hi, just poking this bug report to voice support for sorting $(wildcard)
again. It would be more efficient than patching hundreds of upstream

Yes, I understand that "if upstream projects want reproducible builds
everywhere they should use $(sort)". That is not incompatible with supporting
a sorted $(wildcard) in GNU make. This would improve the default situation at
least for GNU/Linux distributions where GNU make is the default. (And it's
2017, this is the majority use-case in the FOSS world at least.)

Later, other Make implementations might follow suit, and we'd welcome this as
well - and would actively pursue this, when we find time to do that.

I investigated this issue with Bernhard originally, and also was curious at
the lack of documentation pointing to specific discussion around the
"performance" issue. Looking at the code, what was actually changed in
b9f831b8 was the utility function multi_glob (which today is parse_file_seq),
which is also used at various other parts of the code not related to

What I *conjecture* is that, if there was a performance issue, it might have
been related to those other uses of multi_glob / parse_file_seq and not
$(wildcard) itself. (The commit doesn't mention $(wildcard)). Does that ring
any bells, Paul? In which case, one possible fix might be to add a SORT
parameter to parse_file_seq, make it false by default, but in func_wildcard
make it true. Then that would preserve whatever performance improvements that
the original code might have made.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]