[bug #52912] minor bug in GNU make's own Makefile under .ONESHELL

[David Boyce]

URL:
  <http://savannah.gnu.org/bugs/?52912>

                 Summary: minor bug in GNU make's own Makefile under .ONESHELL
                 Project: make
            Submitted by: boyski
            Submitted on: Tue 16 Jan 2018 02:12:06 PM UTC
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
       Component Version: 4.2.1
        Operating System: POSIX-Based
           Fixed Release: None
           Triage Status: None

    _______________________________________________________

Details:

This is a very minor bug but easily fixed (patch inline). A recipe in
Makefile.in has two consecutive lines starting with @ which the manual says is
incompatible with .ONESHELL unless the shell is recognized as
POSIX-compatible. Therefore, when overriding both i.e.:

# make --eval=.ONESHELL: SHELL=<myshell>

The error "@test: command not found" is emitted.

--- Makefile.in 2016-06-10 16:03:22.000000000 -0700
+++ ../../make-4.2.1/Makefile.in        2018-01-15 21:35:02.827437149 -0800
@@ -570,8 +570,8 @@
 $(am__aclocal_m4_deps):

 config.h: stamp-h1
-       @test -f $@ || rm -f stamp-h1
-       @test -f $@ || $(MAKE) $(AM_MAKEFLAGS) stamp-h1
+       @test -f $@ || rm -f stamp-h1 && \
+       test -f $@ || $(MAKE) $(AM_MAKEFLAGS) stamp-h1

 stamp-h1: $(srcdir)/config.h.in $(top_builddir)/config.status
        @rm -f stamp-h1




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52912>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/