[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Case-insensitive targets
From: |
Eli Zaretskii |
Subject: |
Re: Case-insensitive targets |
Date: |
Thu, 02 Aug 2018 17:58:14 +0300 |
> From: Gisle Vanem <address@hidden>
> Cc: address@hidden
> Date: Thu, 2 Aug 2018 16:44:06 +0200
>
> for (s = default_suffix_rules; *s != 0; s += 2, loop++)
> {
> struct file *f = enter_file (strcache_add (s[0]));
> /* This function should run before any makefile is parsed. */
> assert (f->cmds == 0);
>
> I put some trace in this loop and saw that some ".c"/".C",
> ".f"/".F" etc. rules returned 'f->cmds != NULL' and the
> assert() triggers in '-DMAKE_MAINTAINER_MODE'.
>
> From makeint.h:
>
> /* Disable assert() unless we're a maintainer.
> Some asserts are compute-intensive. */
> #ifndef MAKE_MAINTAINER_MODE
> # define NDEBUG 1
> #endif
>
> That assert() doesn't seems to consider Windows.
> Besides, there seems to be a mem-leak in that loop.
I wouldn't be surprised that this mode doesn't work on Windows, I
don't think anyone has ever tried that on that platforms. I certainly
didn't.
- Case-insensitive targets, Gisle Vanem, 2018/08/02
- Re: Case-insensitive targets, Eli Zaretskii, 2018/08/02
- Re: Case-insensitive targets, Gisle Vanem, 2018/08/02
- Re: Case-insensitive targets,
Eli Zaretskii <=
- Re: Case-insensitive targets, Paul Smith, 2018/08/02
- Re: Case-insensitive targets, Eli Zaretskii, 2018/08/02
- Re: Case-insensitive targets, Gisle Vanem, 2018/08/02
- Re: Case-insensitive targets, Paul Smith, 2018/08/02
- Re: Case-insensitive targets, David Boyce, 2018/08/02
- Re: Case-insensitive targets, Eli Zaretskii, 2018/08/03