Re: lib_mvcur.c

[Thomas Dickey]

On Fri, Nov 01, 2002 at 07:16:50AM +0100, Philippe Blain wrote:
> >From Philippe Blain, Bordeaux, FRANCE.
> My old computer: P133 - 8,4 Go - 32 Mo Red Hat Linux 7.0
> 
> To maintainers of 'ncurses'.(and to Mr Dickey)
> Subject: Corrections for ncurses-5.3-20021026+
> 
> Here are some problems I found :
> 
> VIDEO MODES & MVCUR() :
> ----------------------------------------------------------------------------
> File : ncurses/base/lib_mvcur.c
>     .....................
> In 5.3, REAL_ATTR has been deleted on that line (as in 4.2).
> Think REAL_ATTR != A_NORMAL is really missing here.

Will have to test - but it looks likely.  Here's the change comment, which
doesn't mention that line:
 
        revision 1.38
        date: 1997/05/13 15:44:13;  author: Alexander.V.Lukyanov;  state: Exp;  
lines: +2 -250
        moved _nc_mvcur_scrolln() to lib_doupdate.c, to use higher-level 
functions
> 
> 
> More IMPORTANT is the capability 'msgr' (safe to move in standout mode).
> It's the point which should be TESTED in mvcur() with current attributes
> but is not.

Actually, it is tested in tty_update.c, where mvcur is called (GoTo).
Perhaps not the best place...

> If 'msgr' is FALSE, mvcur() should exit standout mode before moving cursor
> or sending a newline, and restore previous attributes at the end.
> 
> And Goto(Y, X) should be nothing else than a call to mvcur(oldY, oldX, Y, X)
> 
> eventually with position checking (in case a bug in optimizer!).

almost: I had the impression that mvcur() isn't supposed to update the screen's
sense of current position (SP->_cursrow, SP->_curscol).  Though not many
programs call mvcur() directly, so it could be changed, I guess.

-- 
Thomas E. Dickey <address@hidden>
http://invisible-island.net
ftp://invisible-island.net