bug-parted
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] getlogin


From: Neal H Walfield
Subject: Re: [patch] getlogin
Date: Thu, 16 Aug 2001 19:26:34 +0200
User-agent: Mutt/1.3.18i

You should not bother applying this patch.  Rather, you should just
elide the call to initgroups completely; it does nothing: initgroups can
_only_ be called by a privileged process (i.e. root).  So, what is
initgroups good for?  Primarily a program like login.  Here is another
patch:

2001-08-16  Neal H Walfield

        * libparted/libparted (ped_init): Do call initgroups.


--- libparted.c.orig    Thu Aug 16 15:00:19 2001
+++ libparted.c Thu Aug 16 19:21:05 2001
@@ -122,9 +122,6 @@ done_disk_types ()
 int
 ped_init ()
 {
-       if (getlogin())
-               initgroups (getlogin(), 0);
-
 #ifdef ENABLE_NLS
        bindtextdomain (PACKAGE, LOCALEDIR);
 #endif

Attachment: pgpWkesz1W0V9.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]