Re: [PATCH parted] msdos_partition_is_flag_available: fix hidden on extended

[Jim Meyering]

Thanks!
I've added NEWS, and for once may refrain from adding a test.

>From 737ff191283d660401edb0422df707a9412e79af Mon Sep 17 00:00:00 2001
From: David Cantrell <address@hidden>
Date: Tue, 2 Mar 2010 09:58:18 +0100
Subject: [PATCH] libparted: msdos_partition_is_flag_available: fix hidden on 
extended
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Since the hidden flag cannot be set on extended partitions,
msdos_partition_is_flag_available() should return 0 for hidden on
extended partitions. Also change msdos_partition_get_flag()
to always return 0 for hidden on extended partitions.
* libparted/labels/dos.c (msdos_partition_is_flag_available):
Return 0 for hidden on extended partitions.
* libparted/labels/dos.c (msdos_partition_get_flag):
Always return 0 for hidden on extended partitions.
* NEWS (Bug fixes): Mention it.
Reported by Flóki Pálsson in http://bugzilla.redhat.com/567118
Patch forwarded by Hans De Goede.
---
 NEWS                   |    7 +++++++
 libparted/labels/dos.c |   10 +++++++++-
 2 files changed, 16 insertions(+), 1 deletions(-)

diff --git a/NEWS b/NEWS
index f6662c8..77a10ca 100644
--- a/NEWS
+++ b/NEWS
@@ -6,6 +6,13 @@ GNU parted NEWS                                    -*- outline 
-*-

   parted now recognizes ATA over Ethernet (AoE) devices

+** Bug fixes
+
+  libparted's msdos_partition_is_flag_available function now always reports
+  that the "hidden" flag is not available for an extended partition.
+  Similarly, msdos_partition_get_flag(p,PED_PARTITION_HIDDEN) always returns 0
+  for an extended partition.
+

 * Noteworthy changes in release 2.2 (2010-02-26) [stable]

diff --git a/libparted/labels/dos.c b/libparted/labels/dos.c
index b83bcc2..6fb4aef 100644
--- a/libparted/labels/dos.c
+++ b/libparted/labels/dos.c
@@ -1467,7 +1467,10 @@ msdos_partition_get_flag (const PedPartition* part, 
PedPartitionFlag flag)
        dos_data = part->disk_specific;
        switch (flag) {
        case PED_PARTITION_HIDDEN:
-               return dos_data->hidden;
+               if (part->type == PED_PARTITION_EXTENDED)
+                       return 0;
+               else
+                       return dos_data->hidden;

        case PED_PARTITION_BOOT:
                return dos_data->boot;
@@ -1498,6 +1501,11 @@ msdos_partition_is_flag_available (const PedPartition* 
part,
 {
        switch (flag) {
        case PED_PARTITION_HIDDEN:
+               if (part->type == PED_PARTITION_EXTENDED)
+                       return 0;
+               else
+                       return 1;
+
        case PED_PARTITION_BOOT:
        case PED_PARTITION_RAID:
        case PED_PARTITION_LVM:
--
1.7.0.1.414.g89213d