bug-parted
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FYI, a few more: gettext, updates from gnulib, typo


From: Jim Meyering
Subject: Re: FYI, a few more: gettext, updates from gnulib, typo
Date: Thu, 27 May 2010 16:00:08 +0200

Petr Uzel wrote:

> On Wed, May 26, 2010 at 09:58:39PM +0200, Jim Meyering wrote:
>> Here are a few more:
>>
>>       fix typo in comment
>>       build: use gettext-0.17
>>       maint: update helper scripts
>>       maint: remove useless definitions
>>       build: update gnulib submodule to latest
>>
>> From bd5754769fa6435a0166192ca1cca531c500694b Mon Sep 17 00:00:00 2001
>> From: Jim Meyering <address@hidden>
>> Date: Wed, 26 May 2010 11:29:56 +0200
>> Subject: [PATCH 03/10] build: use gettext-0.17
>>
>> * configure.ac: Use gettext-0.17.
>> * bootstrap.conf (gnulib_modules): Use gettext-h, not gettext.
>> since the latter drags in a depedency on gettext 0.18.
>> ---
>>  bootstrap.conf |    2 +-
>>  configure.ac   |    2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/bootstrap.conf b/bootstrap.conf
>> index 4ca51a7..9907304 100644
>> --- a/bootstrap.conf
>> +++ b/bootstrap.conf
>> @@ -34,7 +34,7 @@ gnulib_modules="
>>      dirname
>>      fdl
>>      fsync
>> -    gettext
>> +    gettext-h
>>      git-version-gen
>>      gitlog-to-changelog
>>      gnu-web-doc-update
>> diff --git a/configure.ac b/configure.ac
>> index ceecacf..9ae5783 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -295,7 +295,7 @@ libraries.)
>>  fi
>>  AM_PROG_LIBTOOL
>>
>> -AM_GNU_GETTEXT_VERSION([0.15])
>> +AM_GNU_GETTEXT_VERSION([0.18])
>
> Shouldn't this be [0.17] ? ^^^^

Good catch.  Thanks.

That would make it match the log.
Would my requiring 0.18 cause trouble for you personally?
I'm using gettext-0.18 on all of my development systems,
so initially I chose 0.18 there.  But then I figured
I'd make it easier for people who build from git, changed
the log but forgot to change configure.ac.

On one hand, gettext-0.18 does have some desirable improvements,
and little risk of regression, imho.  On the other, I don't want
to make it too hard for others to build from git.  It has no effect
on those who build from a distribution tarball.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]