bug-parted
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Double buffer for fdasd_check_api_version (#693852)


From: Jim Meyering
Subject: Re: [PATCH] Double buffer for fdasd_check_api_version (#693852)
Date: Mon, 09 May 2011 20:59:59 +0200

Jim Meyering wrote:
> Brian C. Lane wrote:
>> diff --git a/libparted/labels/fdasd.c b/libparted/labels/fdasd.c
>>      int api;
>> -    char s[LINE_LENGTH];
>> +    char s[2*LINE_LENGTH];
>>
>>          struct stat st;
>>          if (fstat (f, &st) == 0 && S_ISREG (st.st_mode)) {
>
> Thank you for that patch.
> Sorry I didn't apply that sooner.
> I saw it for the first time only minutes ago.
>
> Subject: [PATCH] s390/dasd: avoid buffer overrun upon API mismatch diagnostic
>
> * libparted/labels/fdasd.c (fdasd_check_api_version): The static
> buffer for the error string was too small.  Double its length.
> This resolves http://bugzilla.redhat.com/693852

Pushed, finally.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]