Re: rcsdiff + revision symbolic names BUG

[Aaron S. Hawley]

After a longer look at the behavior of the named revision bug in rcsdiff
and at RCS's source code, the bug not only affects just long options but
two other options passed on to `diff':

 * the -DNAME (where NAME is some ifdef C macro),
 * and the -y options.

Some relevant source code is attached.  Its not clear just yet what the
fix should be.

/a

On Fri, 5 Aug 2005, Aaron S. Hawley wrote:

> After taking quick look at this bug report, command options like -u, -c,
> -a don't create the behavior in rcsdiff.  It's just some options, notably
> the long options.  And it appears that RCS uses a `co' command when a name
> is specified for the revision, but not for a revision number, nor a lone
> period (.).  But for a branch number with a trailing period (latest
> revision on the named branch), the problem doesn't exist.
>
> /a
>
> On Fri, 5 Aug 2005, Jan Sedlacek wrote:
>
> > Hello,
> >
> > ??? I've found a bug in rcsdiff command.
> >
> > Comparing the same revision using different symbolic names or using
> > revision number and symbolic name gives different result if file
> > contains $Name: $ for different command invocation:
> >
> > >/appl/rcs/bin/rcsdiff -rPOKUS -r1.2 filename
> > ===================================================================
> > RCS file: RCS/filename,v
> > >
> > >/appl/rcs/bin/rcsdiff -rPOKUS -r1.2 --brief filename
> > ===================================================================
> > RCS file: RCS/filename,v
> > retrieving revision 1.2
> > retrieving revision 1.2
> > diff --brief -r1.2 -r1.2
> > Files filename??? 2004/07/26 09:11:51???? 1.2 and filename? 2004/07/26
> > 09:11:51???? 1.2 differ
> > >
> > address@hidden>/appl/rcs/bin/rcsdiff -rPOKUS -r1.2 --text filename
> > ===================================================================
> > RCS file: RCS/filename,v
> > retrieving revision 1.2
> > retrieving revision 1.2
> > diff --text -r1.2 -r1.2
> > 4c4
> > < #--???????? $Name: POKUS $
> > ---
> > > #--???????? $Name:? $
> > address@hidden>
> >
> > If there is no option for the diff command, rcsdiff just compares
> > revisions end exits, but if there is an option for the diff command
> > rcsdiff starts diff command in any case and in result the difference is
> > reported... It's little bit confusing for some users...
> >
> > ??? Regards,
> >
> > ??? Jan

rcsdiff-option-bug.grep
Description: Text document