|
| From: | Jose E. Marchesi |
| Subject: | Re: [bug-recutils] [PATCH] src: always provide encryption routines and their prototypes. |
| Date: | Tue, 27 Mar 2012 20:25:17 +0200 |
| User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) |
> I would prefer a different solution that would make it easier to
> maintain rec-crypt.c: to add a new file rec-crypt-dummy.c which would
> just provide the dummy functions. Then Makefile.am will use rec-crypt.c
> or rec-crypt-dummy.c depending on whether encryption support is being
> compiled in the library.
My only reason for not choosing this way was that it makes it easier to
forget to add a function to rec-crypt-dummy.c. Although both ways make
such problems possible and your makes the file easier to read. Should I
send another patch?
Please. I find it preferable to have to update the dummy variant than
to clobber rec-crypt.c with all those conditional compilation blocks.
--
Jose E. Marchesi http://www.jemarch.net
GNU Project http://www.gnu.org
| [Prev in Thread] | Current Thread | [Next in Thread] |