[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: changelog format

From: Stefano Lattarini
Subject: Re: changelog format
Date: Tue, 17 Jan 2012 14:54:35 +0100

On 01/17/2012 02:43 PM, Thien-Thi Nguyen wrote:
> () Stefano Lattarini <address@hidden>
> () Tue, 17 Jan 2012 13:09:34 +0100
>        * src/ls.c: Two phases of processing are time-consuming enough that
>        they can provoke this: the readdir loop and the printing loop.  The
>        printing was supposed to be covered by a call to process_signals in
>        (print_name_with_quoting): ... but that call was mistakenly guarded
>        by a condition that might be false for many or even all files being
>        processed.  Call process_signals unconditionally.
>        (print_dir): Also call process_signals in the readdir loop.
>        * NEWS (Bug fixes): Mention it.
>        Report by Arkadiusz Miskiewicz.
> I just noticed: The Report line is below the usual mass of
> contiguous *-entries.  Shouldn't it be above?  (Either that, or
> "part of" the mass, i.e., part of a specific *-entry.)
It's fine by me to move the "Reported by" line above the "*-entries mass".
In my previous message, it appeared below simply because it does so in the
original, "real" commit log message I took as a source; but that doesn't
mean we can't tweak that in our example, to make it more conforming to the
new "best practices".


reply via email to

[Prev in Thread] Current Thread [Next in Thread]