[Bug-tar] problems in src/utf8.c

[Bruno Haible]

Hi,

tar-1.14/src/tar.c has the following problems:

1) It uses HAVE_LIBICONV which is never defined by the autoconf macros.
The macro that is defined is HAVE_ICONV.

2) The function get_input_charset() ignores the POSIX way to get at
the encoding, namely nl_langinfo(CODESET). It assumes that the encoding
depends on the language and territory only, which is often not the case.
For example, glibc comes with de_DE.ISO-8859-1, de_DE.ISO-8859-15, de_DE.UTF-8
- three different encodings for one language and territory! Furthermore
get_input_charset() makes destructive modifications to the LC_ALL or
LANG environment variable, which is a usually no-no.

I would recommend to use the 'localcharset' module from gnulib.

Bruno