Re: [Bug-tar] tar-1.15.1+: numerous bugs in xheader.c

[Jim Meyering]

Paul Eggert <address@hidden> wrote:
> Jim Meyering <address@hidden> writes:
...
>> Here's a patch that fixes all of the above problems:
>
> I reviewed it and found a bunch more problems in the neighborhood,
> mostly having to do with time stamp handling.  I installed the
> following patch, which fixed most (but not all) the problems I found.

Thanks for the quick work!
Here's a minor tweak for your new timespec_lt function:

2005-06-22  Jim Meyering  <address@hidden>

        * src/common.h (timespec_lt): Add a return type: bool.

Index: src/common.h
===================================================================
RCS file: /cvsroot/tar/tar/src/common.h,v
retrieving revision 1.55
diff -u -p -r1.55 common.h
--- src/common.h        22 Jun 2005 06:24:39 -0000      1.55
+++ src/common.h        22 Jun 2005 21:42:23 -0000
@@ -191,7 +191,7 @@ GLOBAL struct timespec newer_mtime_optio
   timespec_lt (get_stat_##m##time (&st), newer_mtime_option)
 
 /* Return true if A < B.  */
-static inline
+static inline bool
 timespec_lt (struct timespec a, struct timespec b)
 {
   return a.tv_sec < b.tv_sec || (a.tv_sec == b.tv_sec && a.tv_nsec < 
b.tv_nsec);