[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-tar] [PATCH] Don't inhibit large file support.
|
From: |
Eric Blake |
|
Subject: |
Re: [Bug-tar] [PATCH] Don't inhibit large file support. |
|
Date: |
Sat, 06 Feb 2010 14:44:30 -0700 |
|
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 |
According to Sergey Poznyakoff on 2/6/2010 2:33 PM:
> Yes, it should. Thanks for the patch. However, I'd say it's second
> part:
>
>> - if (fseek (fp, 0L, SEEK_SET) != 0)
>> + if (fseeko (fp, 0L, SEEK_SET) != 0)
>
> is superfluous. When searching for 0, it makes no difference which
> function to use.
Yes, it DOES make a difference. If the current offset of the file is >
2GiB, then fseek MUST fail, even for a seek of 0.
--
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
signature.asc
Description: OpenPGP digital signature