bug-tar
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-tar] tests/extrac07.at


From: Solar Designer
Subject: Re: [Bug-tar] tests/extrac07.at
Date: Mon, 29 Mar 2010 13:46:30 +0400
User-agent: Mutt/1.4.2.3i

Sergey,

On Sat, Mar 27, 2010 at 10:38:46PM +0200, Sergey Poznyakoff wrote:
> Solar Designer <address@hidden> ha escrit:
> 
> But this:
> > +
> > +chmod +w ustar/out/dir
> 
> is entirely useless.  The testsuite script itself takes care of the
> privileges before removing test directories (see
> at_func_group_postprocess).

I think it's not so simple.  Somehow the directory appeared to be
getting removed correctly shortly after we updated the package to 1.23
(although I wouldn't vouch for that now), but later rebuilds of the
package started to produce the following:

 29: mode of extracted directories                ok
 30: extracting symlinks to a read-only dir       ok
rm: cannot remove 
`/usr/src/world/rpm-work-1/BUILD/tar-1.23/tests/testsuite.dir/030/posix/out/dir/foo':
 Permission denied
rm: cannot remove 
`/usr/src/world/rpm-work-1/BUILD/tar-1.23/tests/testsuite.dir/030/gnu/out/dir/foo':
 Permission denied
rm: cannot remove 
`/usr/src/world/rpm-work-1/BUILD/tar-1.23/tests/testsuite.dir/030/oldgnu/out/dir/foo':
 Permission denied
rm: cannot remove 
`/usr/src/world/rpm-work-1/BUILD/tar-1.23/tests/testsuite.dir/030/ustar/out/dir/foo':
 Permission denied
rm: cannot remove 
`/usr/src/world/rpm-work-1/BUILD/tar-1.23/tests/testsuite.dir/030/v7/out/dir/foo':
 Permission denied
 31: restoring mode on existing directory         ok
 32: single-volume label                          ok

The patch that I posted fixed that.

Yes, at_func_group_postprocess has:

          find "$at_group_dir" -type d ! -perm -700 -exec chmod u+rwx \{\} \;

I don't know why this was not sufficient for our recent builds of the
tar package, shortly before applying the extrac07.at patch.

Alexander




reply via email to

[Prev in Thread] Current Thread [Next in Thread]