[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-tar] Incorrect listing of sparse files with more than 8G of rea
|
From: |
Pavel Raiskup |
|
Subject: |
Re: [Bug-tar] Incorrect listing of sparse files with more than 8G of real data |
|
Date: |
Wed, 29 Oct 2014 22:58:35 +0100 |
|
User-agent: |
KMail/4.14.1 (Linux/3.16.6-200.fc20.x86_64; KDE/4.14.1; x86_64; ; ) |
On Wednesday 29 of October 2014 21:16:09 Niessen, Chris wrote:
> Thanks for getting back to me on this. Let me see if I can explain my
> reasoning on how I was assigning to stat.st_size and archive_file_size.
IIRC (the patch itself would be definitely more readable though), you
implemented the older patch
http://www.mail-archive.com/bug-tar%40gnu.org/msg03910.html where
you have "!=" instead of ">" which is the right way imo. My older patch
was bad because the ustar header can theoretically have arbitrary value
when the 'size' extended header is also used; and then the ustar header
shall be ignored (the > was not doing it right).
Thanks, Pavel