[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug-tar] [PATCH] tests: avoid test failure with non-ancient autoconf
From: |
Jim Meyering |
Subject: |
[Bug-tar] [PATCH] tests: avoid test failure with non-ancient autoconf |
Date: |
Sun, 25 Mar 2018 13:29:13 -0700 |
Hi Sergey,
Here's a patch I found useful.
There's probably a way to make AS_ECHO_N work in this context,
but IMHO, the obfuscation is not worth the nominal portability,
since this type of trivial printf use has worked everywhere
for a decade or so.
Thanks,
Jim
>From d9eb3f100a11321903579ef2bb075cdca8e7389d Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Fri, 23 Mar 2018 22:27:44 -0700
Subject: [PATCH] tests: avoid test failure with non-ancient autoconf
Running "make check" would fail with this:
T-nonl.at:30: error: m4_divert_push: cannot change diversion
to `GROW' inside m4_expand
* tests/T-nonl.at: Use printf in place of AS_ECHO_N.
These days, printf should work for everyone.
---
tests/T-nonl.at | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tests/T-nonl.at b/tests/T-nonl.at
index c14dfb2..9cfa943 100644
--- a/tests/T-nonl.at
+++ b/tests/T-nonl.at
@@ -29,9 +29,8 @@ AT_KEYWORDS([files-from nonewline nonl T-nonl])
AT_TAR_CHECK([
genfile --length=0 --file empty
-AS_ECHO_N(c) > 1.nonl
-echo d > 2.nonl
-AS_ECHO_N(e) >> 2.nonl
+printf c > 1.nonl
+printf 'd\ne' > 2.nonl
touch a b c d e
AT_DATA([filelist],[a
b
@@ -59,4 +58,3 @@ c
[],[],[],[ustar])
AT_CLEANUP
-
--
2.17.0.rc1.35.g90bbd502d
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Bug-tar] [PATCH] tests: avoid test failure with non-ancient autoconf,
Jim Meyering <=