[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-tar] tar HEAD: difflink.at portability issue
From: |
Pavel Raiskup |
Subject: |
Re: [Bug-tar] tar HEAD: difflink.at portability issue |
Date: |
Fri, 27 Apr 2018 10:56:02 +0200 |
On Thursday, April 26, 2018 7:01:05 PM CEST Christian Weisgerber wrote:
> In the tar 1.30 release there was a problem with the difflink.at
> test; this has been fixed in HEAD. However, the test still fails
> on *BSD and there is an underlying portability issue.
>
> The preparatory part of the test runs this:
>
> mkdir a
> genfile -f a/x
> ln -s x a/y
> ln a/y a/z
>
> What is the expected result?
It is regression test for 1bf590ab fix, which changed tar's reporting like:
- a/z: Not linked to a/z
+ a/z: Not linked to a/y
So one could add ./configure check to detect that 'ln -P' works, and then
invent some test magic in difflink.at.. But IMO it would be fine enough
to just fix the test so it is working with regular-file hardlinks.
Pavel