[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

gendocs.sh bug

From: Eric Blake
Subject: gendocs.sh bug
Date: Wed, 21 Jul 2010 10:17:59 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.0.5

I noticed this output while running gendocs:

Making .tar.gz for sources...
tar: Removing leading `/' from member names

Sure enough, the resulting tarball contains spurious directories:

$ tar tf doc/manual/autoconf.texi.tar.gz

It looks like this portion of gendocs.sh should be using tar's -C option
(or, if that is not portable, doing an appropriate subshell and cd "$d"
prior to running tar):

> echo Making .tar.gz for sources...
> d=`dirname $srcfile`
> srcfiles=`ls $d/*.texinfo $d/*.texi $d/*.txi $d/*.eps 2>/dev/null` || true
> tar cvzfh $outdir/$PACKAGE.texi.tar.gz $srcfiles

so as to include just the source files, rather than bogus intermediate
directories that expose information about the machine of the person that
ran gendocs.sh.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]