Re: Bug#656659: info not showing anything with certain build flags

[Julian Gilbey]

On Wed, Apr 18, 2012 at 10:07:24AM +0300, Sergey Poznyakoff wrote:
> Norbert Preining <address@hidden> wrote:
> 
> >     footnotes.c: In function ‘info_show_footnotes’:
> >     footnotes.c:258:11: error: format not a string literal and no format 
> > arguments [-Werror=format-security]
> >     footnotes.c:262:11: error: format not a string literal and no
> >     format arguments [-Werror=format-security]
> 
> It is intended (see the comment in info.c:692-695, for the reason of
> it). I'll see if this can be rewritten some other way to pacify gcc, but
> for the time being you'll have to drop that `-Werror' option.

Indeed it can be written in another way:

   info_error("%s", msg_no_foot_node);

and similarly for the next case.  Then you won't have an empty format
argument list.  The same applies to the cases in infodoc.c, infomap.c
(line 942) and session.c (lots of cases, including line 1295).

A diff against the latest CVS version of the info directory is
attached.

   Julian

info.diff
Description: Text Data