Re: [Bug-wget] [PATCH] TLS SNI support

[Micah Cowan]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Phil Pennock wrote:
> On 2009-04-01 at 09:51 +0200, Petr Pisar wrote:
>>> +/* Determine whether or not a hostname is an IP address that we recognise. 
>>> */
>>> +bool
>>> +is_ip_address (const char *name)
>>> +{
>>> +  const char *endp;
>>> +
>>> +  endp = name + strlen(name);
>>> +  if (is_valid_ipv4_address(name, endp))
>>> +    return true;
>>> +#ifdef ENABLE_IPV6
>>> +  if (is_valid_ipv4_address(name, endp))
>>                   ^^^^
>> is_valid_ipv6_address() should be called here.
> 
> Good catch, thanks.  Typotastic.
> 
> Is the protocol to submit a new patch with this fixed or to just declare
> this so simple that the committer fixes it up?

I've updated the issue filed in our bug-tracker in it.

The maintainer *ahem* finds himself with scant spare time these days,
and is beginning to find himself with a backload of fairly
straightforward (and otherwise) patches that he hasn't gotten his shit
together enough to review. He is, however, making an effort to at least
ensure they are being tracked so they're not forgotten.

I'm sorry to be such a bottle-neck. :\

- --
Micah J. Cowan
Programmer, musician, typesetting enthusiast, gamer.
Maintainer of GNU Wget and GNU Teseq
http://micah.cowan.name/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknT93UACgkQ7M8hyUobTrE5AgCeNH3iokreDvdDN1twKuZX3dGs
AhcAn09fHq5IrbJ8yesyxnoj9NUPcUxI
=+FXJ
-----END PGP SIGNATURE-----