bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH] [wget-bug #33210], Add an option to output bandwi


From: Sasikanth
Subject: Re: [Bug-wget] [PATCH] [wget-bug #33210], Add an option to output bandwidth in bits
Date: Wed, 18 Jan 2012 17:43:41 +0530

On Sun, Jan 15, 2012 at 8:51 PM, Hrvoje Niksic <address@hidden> wrote:

> Sasikanth <address@hidden> writes:
>
> > No one asked. i had just thought it will be good to display all the
> output
> > in either bits or bytes to avoid confusion to the user (I had
> > confused).
>
> I understand that, but I have never seen a downloading agent output data
> length in bits, so displaying the data in bits would likely cause much
> more confusion and/or be less useful.  (Data throughput in bits, on the
> other hand, is quite common.)  With the original implementation of
> --bits I expect that someone would soon ask for
> --bits-for-bandwidth-only.
>
> > Anyhow thanks I will modify the patch.
>
> Thanks.
>
> Note that the patch has another problem: while Wget's "K", "M", and "G"
> refer to (what is now known as) kibibytes, mebibytes, and gibibytes,
> bandwidth is measured in kilobits, megabits, and gigabits per second.
> Bandwidth units all refer to powers of ten, not to powers of two, so it
> is incorrect for calc_rate to simply increase the byte multipliers by 8.
>
> Hrvoje
>

  Modified the calc_rate function to calculate bandwidth in powers of ten
(SI-prefix format)
  for --bits option.

 Please review the changes

  Thanks
  Sasi

Attachment: bug33210_added_option_bits_bandwidth_in_bits.txt
Description: Text document

Attachment: Changelog.txt
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]