[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Two fixes: Memory leak with chunked responses / Chunked r

From: Giuseppe Scrivano
Subject: Re: [Bug-wget] Two fixes: Memory leak with chunked responses / Chunked responses and WARC files
Date: Sat, 28 Jan 2012 14:09:55 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)


thanks for your patches.  I have pushed them.


Gijs van Tulder <address@hidden> writes:

> Hi,
> Here are two small patches. I hope they will be useful.
> First, a patch that fixes a memory leak in fd_read_body (src/retr.c)
> and skip_short_body (src/http.c) when it retrieves a response with
> "Transfer-Encoding: chunked". Both functions make calls to
> fd_read_line but never free the result.
> Second, a patch to the fd_read_body function that changes the way
> chunked responses are saved in the WARC file. Until now, wget would
> write a de-chunked response to the WARC file, which is wrong: the WARC
> file is supposed to have an exact copy of the HTTP response, so it
> should also include the chunk headers.
> The first patch fixes the memory leaks. The second patch changes
> fd_read_body to save the full, chunked response in the WARC file.
> Regards,
> Gijs

reply via email to

[Prev in Thread] Current Thread [Next in Thread]