[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] Patch: Make wget abort if post-file does not exist
From: |
Giuseppe Scrivano |
Subject: |
Re: [Bug-wget] Patch: Make wget abort if post-file does not exist |
Date: |
Mon, 11 Mar 2013 21:33:35 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) |
Thanks for your your patch! Some comments:
Darshit Shah <address@hidden> writes:
> Attaching a patch to make wget abort instead of sending an empty request if
> the file pointed to in --post-file does not exist.
+ return FILEBADFILE;
what exit status will be returned by the wget process?
I am not sure FILEBADFILE is handled by get_exit_status (in exits.c). I
think we should ensure the exit status is 3 in this case (File I/O
error).
As additional bonus, could you write a simple test case to exercise your
code?
You can copy the Test-noop.px file as a starting point then change the
cmdline to something like (add the new file to the Makefile.am file too):
my $cmdline = $WgetTest::WGETPATH . " --post-file=nothere
http://localhost:{{port}}/";
Then you can check that the expected_error_code is 3.
Cheers,
Giuseppe