Re: [Bug-wget] wget-1.14.128: please use string-format instead

[Darshit Shah]

Hi Jochen,

This issue was reported yesterday too. The issue as I described on that
thread is that the quotearg_style() function in gnulib caches the output
causing wget to return the wrong output if your patch is applied. That was
the chief reason that caused us to break the old string.

On Mon, Jun 3, 2013 at 1:43 AM, Jochen Hein <address@hidden> wrote:

>
> Hi,
>
> in src/cookies.c:687 you have:
>
>       if (!check_domain_match (cookie->domain, host))
>         {
>           logprintf (LOG_NOTQUIET,
>                      _("Cookie coming from %s attempted to set domain to
> "),
>                      quotearg_style (escape_quoting_style, host));
>           logprintf (LOG_NOTQUIET,
>                      _("%s\n"),
>                      quotearg_style (escape_quoting_style,
>         cookie->domain));
>           cookie->discard_requested = true;
>         }
>
> In older releases we had a format string with two "%s", so
> cookie->domain had not to be at the end of the translation.
> Please use something like the following patch (untested):
>
> --- src/cookies.c.orig  2013-06-02 22:12:00.000000000 +0200
> +++ src/cookies.c       2013-06-02 22:12:45.000000000 +0200
> @@ -684,10 +684,8 @@
>        if (!check_domain_match (cookie->domain, host))
>          {
>            logprintf (LOG_NOTQUIET,
> -                     _("Cookie coming from %s attempted to set domain to
> "),
> -                     quotearg_style (escape_quoting_style, host));
> -          logprintf (LOG_NOTQUIET,
> -                     _("%s\n"),
> +                     _("Cookie coming from %s attempted to set domain to
> %s\n"),
> +                     quotearg_style (escape_quoting_style, host),
>                       quotearg_style (escape_quoting_style,
> cookie->domain));
>            cookie->discard_requested = true;
>          }
>
> Jochen
>
> --
> The only problem with troubleshooting is that the trouble shoots back.
>
>
>


-- 
Thanking You,
Darshit Shah