[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] cmd_string_uppercase
|
From: |
Giuseppe Scrivano |
|
Subject: |
Re: [Bug-wget] cmd_string_uppercase |
|
Date: |
Sat, 22 Jun 2013 14:07:46 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Ángel González <address@hidden> writes:
> I noticed a gcc warning on cmd_string_uppercase() and ended up almost
> rewriting it, since I disliked the extra copy by cmd_string.
>
> Also note that the if (!ret || q == NULL) was useless, since
> cmd_string always returns true, and q would never be NULL (it would
> have crashed inside xstrdup, see gnulib/lib/xmalloc.c).
thanks, I have added the ChangeLog entry and pushed it.
--
Giuseppe