[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] Race condition on downloaded files among multiple wget in
From: |
Tim Ruehsen |
Subject: |
Re: [Bug-wget] Race condition on downloaded files among multiple wget instances |
Date: |
Tue, 03 Sep 2013 10:06:51 +0200 |
User-agent: |
KMail/4.10.5 (Linux/3.10-2-amd64; KDE/4.10.5; x86_64; ; ) |
On Tuesday 03 September 2013 03:48:15 Tomas Hozza wrote:
> > BTW, read() instead of mmap() would not help in this case.
>
> It would eliminate the SIGBUS because the length of the file
> is determined from the number of read bytes by read(). This way
> we might end up with truncated file, but will not try to access
> the memory where we shouldn't.
In this case, the (or some) links couldn't be followed and the test could have
succeeded without doing the expected action. The tester maybe wouldn't have
recognized the fault. In your special case, the tester maybe would not mind,
but in general it is a good idea not to suppress errors or misbehavior, just
to make people feel better.
Regards, Tim
- [Bug-wget] Race condition on downloaded files among multiple wget instances, Tomas Hozza, 2013/09/03
- Re: [Bug-wget] Race condition on downloaded files among multiple wget instances, Tim Ruehsen, 2013/09/03
- Re: [Bug-wget] Race condition on downloaded files among multiple wget instances, Tomas Hozza, 2013/09/03
- Re: [Bug-wget] Race condition on downloaded files among multiple wget instances,
Tim Ruehsen <=
- Re: [Bug-wget] Race condition on downloaded files among multiple wget instances, Daniel Stenberg, 2013/09/03
- Re: [Bug-wget] Race condition on downloaded files among multiple wget instances, Darshit Shah, 2013/09/03
- Re: [Bug-wget] Race condition on downloaded files among multiple wget instances, Tim Ruehsen, 2013/09/03
- Re: [Bug-wget] Race condition on downloaded files among multiple wget instances, Daniel Stenberg, 2013/09/03
- Re: [Bug-wget] Race condition on downloaded files among multiple wget instances, Tim Ruehsen, 2013/09/04
- Re: [Bug-wget] Race condition on downloaded files among multiple wget instances, Ángel González, 2013/09/03
- Re: [Bug-wget] Race condition on downloaded files among multiple wget instances, Tim Ruehsen, 2013/09/04
- Re: [Bug-wget] Race condition on downloaded files among multiple wget instances, Ángel González, 2013/09/04
- Re: [Bug-wget] Race condition on downloaded files among multiple wget instances, Tomas Hozza, 2013/09/09
- Re: [Bug-wget] Race condition on downloaded files among multiple wget instances, Anthony Bryan, 2013/09/09