Re: [Bug-wget] [PATCH] Using parallel test harness

[Darshit Shah]

On Thu, Sep 25, 2014 at 11:40:57AM +0200, Tim Ruehsen wrote:
> Hi,
> 
> here is patch version #2.
> 
> - fixed some little scratches
> - got rid of WgetTest.pm.in (WgetTest.pm now reads $top_srcdir from ENV).
> - got rid of run-px
> 
> With these changes you can make use of TESTS_ENVIRONMENT variable, e.g.
>       TESTS_ENVIRONMENT="LC_ALL=tr_TR.utf8" make check -j4
> 
> To run the tests with a turkish locale.
> ;-) Some tests break, but I am up to fix a few (e.g. the perl FTP server has 
> a 
> locale issue which I already fixed - patch comes today).
> 
Hi Tim,

A couple of points about this patch. The patch now puts the WgetTest.pm file
under version control. Everyone who already has a development environment for
Wget already setup will not be able to apply this patch without manual
intervention.

Instead, I suggest that we rename WgetTest.pm to something else so that the
conflict does not arise. It could be called WgetTests.pm for example.

The WgetTest.pm file included in this patch contains the old Warning for an
autogenerated file. Maybe we should remove that one since the file is no longer
being autogenerated.

Do you think having the tests being run in a different locale is necessary? I
feel that the same reasoning that was applied to DEBUGP() messages should apply
here. The tests and their output is meant for debugging by the developers and
hence should remain in English. If Wget seems to be breaking for some locale, we
can write a specific test case for that.

> > In my opinion, the two test suites should be kept separate, atleast for the
> > time being while the new test suite is completed.
> 
> I agree. To keep it clean we shouldn't mix python and perl tests.
> 
> Thanks for your feedback, Darshit.
> 
> Tim
>

pgpFgNBZ3hmhL.pgp
Description: PGP signature