Re: [Bug-wget] [PATCH] Using parallel test harness

[Darshit Shah]

> On 09/27, Tim Rühsen wrote:
> Am Sonntag, 28. September 2014, 01:00:40 schrieb Darshit Shah:
> > >patch version #3 is attached
> >
> > Hi Tim,
> >
> > I just wanted to point out that there is a blocking issue with this patch.
> > It eliminates the ability for the user to execute single tests directly. I
> > can run `make check` without much issues but I cannot execute a single test
> > by directly invoking it. The $src_topdir variable isn't being set correctly
> > in that case.
> >
> > In my opinion, that is an extremely important feature when debugging Wget
> > with a single failing test, or when writing a new test.
>
> Hi Darshit,
>
> that's a good point.
>
> A make check -j4 just takes a few seconds on my machine, so I wouldn't mind.
> But yes, there might me much slower machines...

It's not just about the time. Sometimes, I find it very convenient to be able to 
run a test and look at its output on the screen directly instead of having to 
open its log file. This is something I do when testing a new feature or some 
change in Wget which has chances of regressions occurring in it.
> Some tests require to have $top_srcdir in the old test suite as well
> (e.g.Test-proxied-https-auth.px). How do you execute these directly ?
I remember being able to directly execute Test-proxied-https eithout issues in 
the past. However, when I tried doing the same right now, I had a couple of 
issues with OpenSSL that I haven't yet debugged. Though, as I stated in the 
other mail I sent out today, that particular test has often and randomly failed 
for me and then started working againwithout anything else changing. Right now, 
I get the following error:

> --2015-09-28 01:50:04--  https://no.such.domain/needs-auth.txt
> Resolving localhost (localhost)... ::1, 127.0.0.1
> Connecting to localhost (localhost)|::1|:45437... failed: Connection refused.
> Connecting to localhost (localhost)|127.0.0.1|:45437... connected.
> OpenSSL: error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert 
> handshake failure
> Couldn't initiate SSL at ./Test-proxied-https-auth.px line 68.
> Unable to establish SSL connection.
> Got code: 1024

However, running `./Test-proxied-https.px ../` from the tests/ directory makes 
the test execute perfectly for me. Looking at the test source, it seems a 
snippet was added to ensure that $top_srcdir could be explicitly set when trying 
to directly invoke the script.
> I don't have the sources here, I'll take a closer look at it on Monday.
>
> Tim



--
Thanking You,
Darshit Shah

pgpdF3JnRqvMT.pgp
Description: PGP signature