Re: [Bug-wget] Configure cleanup

[Tim Ruehsen]

On Monday 17 November 2014 19:39:12 Darshit Shah wrote:
> On 11/17, Tim Rühsen wrote:
> >On Monday 17 November 2014 09:48:30 Darshit Shah wrote:
> >> On 11/16, Tim Rühsen wrote:
> >> >Am Sonntag, 16. November 2014, 16:59:18 schrieb Darshit Shah:
> >> >> I cleanup up configure.ac slightly.
> >> >> 
> >> >> It's not complete, but this is in my opinion a step up from what we
> >> >> had
> >> >> already. If everyone is fine with it, I'll push this version of the
> >> >> patch.
> >> >> 
> >> >> The first patch adds the -Wextra CFLAG by default on systems where a
> >> >> CFLAG
> >> >> variable is not already defined.
> >> >
> >> >It works for me, just a comment.
> >> >
> >> >configure.ac seems to have 2 spaces indentation - now we have 4 spaces
> >> >mixed with 2 spaces indentation. At some places the indentation is
> >> >wrong.
> >> >I personally prefer 2 spaces - but it really doesn't matter. Maybe you
> >> >amend configure.ac so that we have the same indentation everywhere !?
> >> 
> >> You're right. The indentation and formatting is quite a bit off. In fact,
> >> that is one reason which is preventing any further work on the
> >> configure.ac
> >> file for me.
> >> 
> >> I'm stuck and unable to understand how that code ought to be formatted.
> >> I'll look into it once again and see if I can finally format it with two
> >> spaces and other stylistic guidelines.
> >
> >I prefer 2 spaces indent (but just make your own choice). As long as the
> >formatting is consistent throughout the whole file.
> 
> Forget it. This works right now and I'm not going to touch the configure
> code unless really required.
> 
> Slight changes are breaking the entire build system for me. Trash these
> patches.

Indentation should not break anything !?
I had issues when changing configure.ac as well - though they all were my own 
faults, either f*cking up brackets or macro misspelling (e.g. AS_IF instead 
AC_IF). These things are often reported far away from the point where they 
are. So you stare and stare and can't see anything.
My strategy now is to autoreconf after each little change and if it breaks, 
CTRL-z until it works again, than continue changes at that point...

But of course, don't waste your time with these things.

> >Tim
> 
> --- end quoted text ---

signature.asc
Description: This is a digitally signed message part.