Re: [Bug-wget] [PATCH] Fixing C89 warnings

[Tim Ruehsen]

On Thursday 20 November 2014 15:06:26 Gisle Vanem wrote:
> Tim Ruehsen wrote:
> > You don't have the latest git version, at least your diff isn't based on
> > it.
> Okay. I was too quick. It builds fine with MSVC v16 except
> for http.c and the rubbish in progress.c. See [1] below.
> Diffs for http.c:

That are good news.

> --- ../Git-latest/src/http.c    2014-11-20 15:39:55 +0000
> +++ ./http.c    2014-11-20 15:54:05 +0000
> @@ -1191,8 +1191,9 @@
>   parse_content_disposition (const char *hdr, char **filename)
>   {
>     param_token name, value;
> -  *filename = NULL;
>     bool is_url_encoded = false;
> +
> +  *filename = NULL;
>     for ( ; extract_param (&hdr, &name, &value, ';', &is_url_encoded);
>           is_url_encoded = false)

I pushed it.

> [1]:
>    #else
>    # define count_cols(mbs) ((int)(strlen(mbs)))
>    # define cols_to_bytes(mbs, cols, *ncols) do {  \
>        *ncols = cols;                              \
>        bytes = cols;                               \
>    }while (0)
>    #endif
> 
> (I forgot to add 'HAVE_WCWIDTH' and 'HAVE_MBTOWC').

? could you send a patch ? I am not sure what to fix here.

> And BTW. Since large-files are default on Windows (wgint is
>    __int64), this patch should be applied:
> 
> --- ../Git-latest/src/build_info.c.in   2014-10-30 13:33:41 +0000
> +++ ./build_info.c.in   2014-11-05 13:28:49 +0000
> @@ -2,11 +2,12 @@
>   https           defined HAVE_SSL
>   ipv6            defined ENABLE_IPV6
>   iri             defined ENABLE_IRI
> -large-file      SIZEOF_OFF_T >= 8
> +large-file      SIZEOF_OFF_T >= 8 || defined WINDOWS

Does this hold true for Win32 (WinXP 32bit) ?
Or do we have to amend this check ?

Tim

signature.asc
Description: This is a digitally signed message part.