Re: [Bug-wget] [PATCH] Replaced-xfree_null-by-xfree-and-nullify-argument-aftfer-freeing

[Tim Ruehsen]

On Monday 01 December 2014 12:59:26 Giuseppe Scrivano wrote:
> Tim Rühsen <address@hidden> writes:
> > This patch removes xfree_null() and replaces it by xfree().
> > xfree() automatically nullifies the argument after freeing to reduce
> > dangling pointer problems like double frees.
> > 
> > I also cleaned up code like
> > 
> >     if (p)
> >     
> >       xfree (p);
> > 
> > and
> > 
> >     xfree(p);
> >     p = NULL;
> > 
> > Both cases reduce to a call to xfree(p).
> > 
> > check and distcheck tested, also valgrind tested.
> > 
> > Please review and comment.
> > 
> > Tim
> > 
> > From ede5a27de1e2e5447ec31a918af789e657b53b1b Mon Sep 17 00:00:00 2001
> > From: Tim Ruehsen <address@hidden>
> > Date: Sat, 29 Nov 2014 17:54:20 +0100
> > Subject: [PATCH] Replaced xfree_null() by xfree() and nullify argument
> > after> 
> >  freeing.
> 
> ACK

Pushed.

Tim

signature.asc
Description: This is a digitally signed message part.