[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] no_proxy env ip address range support

From: Aníbal Limón
Subject: Re: [Bug-wget] no_proxy env ip address range support
Date: Thu, 16 Apr 2015 14:07:34 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0


On 15/04/15 18:38, Ángel González wrote:
On 14/04/15 23:44, Aníbal Limón wrote:
Hi guys,

I noticed that wget only support domain names entries into no_proxy env-var, i think will be good to
add support for IPs and IP ranges.

I reviewed the code and i think can be added to src/retr.c:no_proxy_match , that will be resolv the host to IP if the no_proxy variable contains an IP and then validate if match.

It would be a change that could add?, Comments?

Wouldn't that end up with the domain being resolved *twice*?
Yes the hostname resolution need to be done only once.

Also note that it wouldn't be desirable to apply the suffix matching on IPs (CIDR would very nice,
though -but there's no need for your patch to *also* do that-).

I think the general idea is a good one.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]