[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH 3/3] Redirect containing %2B behaves differently d

From: Darshit Shah
Subject: Re: [Bug-wget] [PATCH 3/3] Redirect containing %2B behaves differently depending on locale
Date: Tue, 21 Apr 2015 19:49:09 +0530
User-agent: Mutt/1.5.23 (2014-03-12)

Hi Ander,

Thanks for the quick turnaround on the patches. I've been a little too busy lately and unable to review the patches.

Firstly, as Tim mentioned earlier, could you please amend your patches to have commit messages that are <= 72 chars per line. Also, please do add your new test to testenv/Makefile.am so that it is automatically executed when running make check.

It would also be a lot cleaner if you could merge your last patch fixing the compiler warning with the original one fixing the bug.

Regarding the patch itself, I wanted to ask if it would not be cleaner to dig into the code and replace every call to url_unescape with the new prototype? In my opinion that would help in maintaining readability and more importantly maintainability of the code.

Apart from those minor issues, I'm okay with the patch.
On 04/21, Ander Juaristi wrote:
On 04/20/2015 04:59 PM, Tim Ruehsen wrote:
Could you please fix this warning (add a prototype):
iri.c: In function 'do_conversion':
iri.c:139:3: warning: implicit declaration of function
'url_unescape_except_reserved' [-Wimplicit-function-declaration]
   url_unescape_except_reserved (in);
url.c:217:1: warning: no previous prototype for 'url_unescape_except_reserved'
 url_unescape_except_reserved (char *s)

This is to be applied on top of it. For some reason, it gives no warnings to me 
(neither now nor before), so please tell me if it all goes well.

- AJ

From 8cc8f44683d8dc8ca1904e088848244d24c202c7 Mon Sep 17 00:00:00 2001
From: Ander Juaristi <address@hidden>
Date: Mon, 20 Apr 2015 23:28:56 +0200
Subject: [PATCH 3/3] Fixed compiler warning.

* src/url.h: Added prototype for url_unescape_except_reserved().
src/url.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/src/url.h b/src/url.h
index b1c46c1..a543f3d 100644
--- a/src/url.h
+++ b/src/url.h
@@ -106,6 +106,7 @@ struct url
char *url_escape (const char *);
char *url_escape_unsafe_and_reserved (const char *);
void url_unescape (char *);
+void url_unescape_except_reserved (char *);

struct url *url_parse (const char *, int *, struct iri *iri, bool 
char *url_error (const char *, int);

Thanking You,
Darshit Shah

Attachment: pgpAgTyW59Qme.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]