[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] pod2man --utf8 -> wget build failure
From: |
Jérémie Courrèges-Anglas |
Subject: |
Re: [Bug-wget] pod2man --utf8 -> wget build failure |
Date: |
Mon, 27 Jun 2016 03:41:35 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (berkeley-unix) |
Tim Ruehsen <address@hidden> writes:
> Please test the attached patch that addresses the pod2man issue.
One minor thing regarding this patch: make is supposed to start commands
using sh -e (POSIX says). -e in a shell approximately means "exit as
soon as you encounter an error". Thus, here:
@@ -57,7 +57,10 @@ wget.pod: $(srcdir)/wget.texi version.texi
$(TEXI2POD) -D VERSION="$(VERSION)" $(srcdir)/wget.texi $@
$(MAN): wget.pod
- $(POD2MAN) --center="GNU Wget" --release="GNU Wget @VERSION@" --utf8 $?
> $@
+ $(POD2MAN) --center="GNU Wget" --release="GNU Wget @VERSION@" --utf8 $?
> $@; \
The code below would not be run in case of an error with --utf8.
+ if [ $? != 0 ]; then \
+ $(POD2MAN) --center="GNU Wget" --release="GNU Wget @VERSION@" $? >
$@; \
+ fi
#wget.cat: $(MAN)
# nroff -man $? > $@
--
2.8.1
As is, the code would work with GNU make, which doesn't use sh -e by
default. OpenBSD make does use sh -e. I thought that this could be
worth reporting.
A simple fix could be something like:
$(MAN): wget.pod
+ $(POD2MAN) --center="GNU Wget" --release="GNU Wget @VERSION@" --utf8 $?
> $@ || \
+ $(POD2MAN) --center="GNU Wget" --release="GNU Wget @VERSION@" $? > $@
--
jca | PGP: 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE