Re: [Bug-wget] TEST_NAME in Python tests?

[Tim Rühsen]

On Samstag, 27. August 2016 20:26:14 CEST Tim Rühsen wrote:
> On Mittwoch, 24. August 2016 20:08:17 CEST Dale R. Worley wrote:
> > In the file testenv/README is:
> >     Next, is the const variable, TEST_NAME that defines the name of the
> > 
> > Test.
> > 
> >     Both, the HTTPTest and FTPTest modules have the same prototype:
> >     {
> >     
> >         name,
> >         pre_hook,
> >         test_options,
> >         post_hook,
> >         protocols
> >     
> >     }
> >     name should be a string, and is usually passed to the TEST_NAME
> > 
> > variable,
> > 
> >     Remember to always name the Test correctly using the TEST_NAME
> >     variable.
> > 
> > This is essential since a directory with the Test Name is created and this
> > can cause synchronization problems when the Parallel Test Harness is used.
> > One can use the following command on Unix systems to check for TEST_NAME
> > 
> > clashes:
> >     $ grep -r -h "TEST_NAME =" | cut -c13- | uniq -c -d
> > 
> > However, *none* of the tests in testenv has a TEST_NAME parameter.
> > 
> > In addition, the HTTPTest class does not have a "name" argument for its
> > constructor.  (See testenv/test/http_test.py, line 15.)
> > 
> > What should be done about this?
> 
> Very good finding.
> name/Test_NAME are remnants. We (well, I :-) removed that some while ago
> (using the file name of the test as unique identifier) and just forgot to
> amend the README.
> See commit 926e42d4678689195a0bbed210c6d027db7cc390
> 
> A patch to correct this would be welcome !

Just pushed a patch the remove these references to TEST_NAME.

Tim

signature.asc
Description: This is a digitally signed message part.