Re: [Bug-wget] 57 failures running testsuite of wget-1.18.109-4734

[Tim Ruehsen]

On Friday, February 3, 2017 9:51:21 AM CET Tim Ruehsen wrote:
> On Thursday, February 2, 2017 6:46:32 PM CET Antonio Diaz Diaz wrote:
> > http.c: In function 'test_parse_range_header':
> > http.c:5124: warning: this decimal constant is unsigned only in ISO C90
> > http.c:5124: warning: this decimal constant is unsigned only in ISO C90
> > http.c:5125: warning: this decimal constant is unsigned only in ISO C90
> > http.c:5125: warning: integer constant is too large for 'long' type
> > http.c:5125: warning: integer constant is too large for 'long' type
> > --------------------------------------------------------------------
> 
> There is no 64bit integer type on your system ? Or the detection does not
> work. How long is 'long long' or off_t in your system ?
> 
> If that is really true, just do not download files larger than 2^31 bytes
> (to be on the save side, maybe 2^32 works out - but you should test it
> well).

Forget it :-) It was just the constants not properly declared. I pushed the 
following patch to fix it on 32bit (with 64bit types available):

diff --git a/src/http.c b/src/http.c
index 9f03d864..99f024d4 100644
--- a/src/http.c
+++ b/src/http.c
@@ -5121,8 +5121,10 @@ test_parse_range_header (void)
       { "bytes 1-999/1000", 1, 999, 1000, true },
       { "bytes 42-1233/1234", 42, 1233, 1234, true },
       { "bytes 42-1233/*", 42, 1233, -1, true },
-      { "bytes 0-2147483648/2147483649", 0, 2147483648, 2147483649, true },
-      { "bytes 2147483648-4294967296/4294967297", 2147483648, 4294967296, 
4294967297, true }
+      { "bytes 0-2147483648/2147483649", 0, 2147483648U, 2147483649U, true },
+#if SIZEOF_WGINT >= 8
+      { "bytes 2147483648-4294967296/4294967297", 2147483648U, 4294967296ULL, 
4294967297ULL, true },
+#endif
   };
 
   wgint firstbyteptr[sizeof(wgint)];
-- 

Regards, Tim

signature.asc
Description: This is a digitally signed message part.