Re: [Bug-wget] PATCH: tests for SSL

[Tim Rühsen]

Hi Vijo,


thanks so much !


I had to manually merge the changes from your patch since I also made
some changes in the meantime. Please continue from branch
'tmp-gitlab-ci' on https://gitlab.com/gnuwget/wget.


I made several changes to get the new Tests going ('make distcheck'
VPATH issues, HOSTALIAS issue, fixed WgetFeature.pm to allow multiple
required features, auto-generate certs/*.conf, cleanup on exit, ...)

There are still some issue to let the tests run in parallel (maybe your
devel system has an old version of automake - so the tests are always
run in serial !?).

Especially we need a own certs/root.conf for each test, else the tests
write to the same file names at the same time (random failures here).

Also, there are remnants like '1122.pem' in the tests/ directory.
Something that a recent 'make distcheck' doesn't allow any more.
I guess they are from 'openssl' tool ... will check tomorrow.

Brrr, Perl is not my favorite, hope I will forget everything I learned
today within the next weeks ;-)


With Best Regards, Tim



On 05/09/2017 04:04 AM, Vijo Cherian wrote:
> Hi Tim,
>   Another revision of the patch is attached.
> 
>  What I changed from last patch :
>        - Skip if the name cannot be resolved
>        - skip if not using openssl as a temp work around till I figure out
> gnutls-openssl cert issues.
> 
> Best,
> Vijo.
> 
> On Thu, May 4, 2017 at 8:01 AM, Tim Rühsen <address@hidden> wrote:
> 
>> Hi Vijo,
>>
>> I fixed what I could fix (as totally Perl ignorant).
>>
>> There is still one issue left that I can't figure out.
>>
>> Test-https-badcerts.px fails here with this in the log:
>>
>>
>> Connecting to wgettestingserver (wgettestingserver)|127.0.0.1|:60443...
>> connected.
>> Created socket 3.
>> Releasing 0x00005571c84304e0 (new refcount 1).
>> GnuTLS: ASN1 parser: Error in DER parsing.
>> Closed fd 3
>> Unable to establish SSL connection.
>> Test failed: wrong code returned (was: 4, expected: 5)
>>
>> $ openssl version
>> OpenSSL 1.1.0e  16 Feb 2017
>>
>>
>>
>> With Best Regards, Tim
>>
>>
>>
>> On 05/02/2017 05:07 PM, Vijo Cherian wrote:
>>> Attached now.
>>>
>>> On Tue, May 2, 2017 at 8:06 AM, Vijo Cherian <address@hidden>
>> wrote:
>>>
>>>> Sorry about that Tim.
>>>> I reworked the patches again.
>>>> This time, I ran 'make check -j4" in a loop overnight.
>>>>
>>>> Best,
>>>> Vijo.
>>>>
>>>> On Sun, Apr 30, 2017 at 5:49 AM, Tim Rühsen <address@hidden> wrote:
>>>>
>>>>> Hi Vijo,
>>>>>
>>>>> maybe I miss something ?
>>>>>
>>>>> $ cat tests/Test-https-pfs.log
>>>>> Running test Test-https-pfs
>>>>> IO::Socket::IP configuration failed at SSLServer.pm line 71.
>>>>> Failed to get ssl sock at SSLServer.pm line 168.
>>>>> Can't call method "accept" on an undefined value at SSLServer.pm line
>> 86.
>>>>>
>>>>> Regards, Tim
>>>>>
>>>>> On Samstag, 29. April 2017 13:21:04 CEST Vijo Cherian wrote:
>>>>>> Thank you for your review and comments, Tim.
>>>>>>
>>>>>> Attached is the revised set of patches for the same tests.
>>>>>>
>>>>>>
>>>>>> Best,
>>>>>> Vijo.
>>>>>>
>>>>>> On Fri, Apr 28, 2017 at 3:42 AM, Tim Rühsen <address@hidden>
>> wrote:
>>>>>>> Hi Vijo,
>>>>>>>
>>>>>>> great work !
>>>>>>>
>>>>>>> There is just a bit of polishing to be done... :-)
>>>>>>>
>>>>>>>
>>>>>>> - some whitespace warnings (maybe you set your editor to remove
>>>>> trailing
>>>>>>> whitespace when saving !?):
>>>>>>>
>>>>>>> .git/rebase-apply/patch:516: trailing whitespace.
>>>>>>> my $revokecmd = "openssl ca -config $caconf -revoke $servercrt &&
>>>>>>> .git/rebase-apply/patch:795: trailing whitespace.
>>>>>>> issuerAltName=issuer:copy
>>>>>>> .git/rebase-apply/patch:802: trailing whitespace.
>>>>>>>
>>>>>>>  certificate = $dir/interca.crt
>>>>>>>
>>>>>>> .git/rebase-apply/patch:865: trailing whitespace.
>>>>>>> issuerAltName=issuer:copy
>>>>>>> .git/rebase-apply/patch:872: trailing whitespace.
>>>>>>>
>>>>>>>  certificate = $dir/test-ca-cert.pem
>>>>>>>
>>>>>>> warning: 5 lines add whitespace errors.
>>>>>>>
>>>>>>>
>>>>>>> - you use the 'openssl' tool from the tests.
>>>>>>> Is it possible to create the required files apart from the tests and
>>>>>>> store them in tests/certs ? You can provide a script and/or a README
>>>>> how
>>>>>>> to create these files (see testenv/certs/README).
>>>>>>> If that is not possible, the tests should see if the 'openssl'
>> command
>>>>>>> is available. If unavailable the test(s) should SKIP.
>>>>>>>
>>>>>>>
>>>>>>> - some tests fail here with 'make check -j4' but succeed with -j1
>>>>>>> (failures are a bit random):
>>>>>>> FAIL: Test-https-tlsv1.px
>>>>>>> FAIL: Test-https-tlsv1x.px
>>>>>>> FAIL: Test-https-clientcert.px
>>>>>>>
>>>>>>>
>>>>>>> - this test always fails (wget is build with GnuTLS):
>>>>>>> FAIL: Test-https-badcerts.px
>>>>>>>
>>>>>>> Releasing 0x0000559c258a74d0 (new refcount 1).
>>>>>>> GnuTLS: ASN1 parser: Error in DER parsing.
>>>>>>> Closed fd 3
>>>>>>> Unable to establish SSL connection.
>>>>>>> Can't use an undefined value as a symbol reference at SSLServer.pm
>>>>> line
>>>>>>> 131.
>>>>>>> Test failed: wrong code returned (was: 4, expected: 5)
>>>>>>> FAIL Test-https-badcerts.px (exit status: 255)
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> With Best Regards, Tim
>>>>>>>
>>>>>>> On 04/27/2017 06:19 AM, Vijo Cherian wrote:
>>>>>>>> Thank you Tim.
>>>>>>>>
>>>>>>>> Attached is the last set of patches from me for SSL testing.
>>>>>>>> I will apply these to wget2 and start working on wget2 from now.
>>>>>>>>
>>>>>>>> Best,
>>>>>>>> Vijo.
>>>>>>>>
>>>>>>>> On Wed, Apr 19, 2017 at 4:12 AM, Tim Rühsen <address@hidden>
>>>>> wrote:
>>>>>>>>> Hi Vijo,
>>>>>>>>>
>>>>>>>>> On 04/18/2017 06:56 PM, Vijo Cherian wrote:
>>>>>>>>>> Added a framework for perl based SSL tests, and some tests to
>>>>> start
>>>>>>>
>>>>>>> with.
>>>>>>>
>>>>>>>>>> In case this is of interest, I will add more tests for SSL: client
>>>>>>>>>> certificates, CRLs, negative tests etc.
>>>>>>>>>> Also not included : making these tests a part of "make check".
>>>>>>>>>>
>>>>>>>>>> TESTING :  only on ubuntu 16
>>>>>>>>>
>>>>>>>>> thank you for this contribution !
>>>>>>>>>
>>>>>>>>> Your commit has been slightly amended (trailing white space
>>>>> removed,
>>>>>>>>> commit message changed to GNU style) and pushed to master.
>>>>>>>>>
>>>>>>>>> Maybe you are interested to inspect Wget2 testing to see if your
>>>>> tests
>>>>>>>>> are already covered there. If not we would be pleased if you could
>>>>> add
>>>>>>>>> them there as well.
>>>>>>>>>
>>>>>>>>> Just 'git clone https://github.com/rockdaboot/wget2' and jump in !
>>>>>>>>>
>>>>>>>>> Regards, Tim
>>>>>
>>>>>
>>>>
>>>
>>
>>
>

signature.asc
Description: OpenPGP digital signature