[Bug-xorriso] Re: -reply:<address@hidden>

[Dagobert Michelsen]

hi Thomas,

Am 17.01.2011 um 15:47 schrieb Thomas Schmitt:
>> I just tried to build the current xorriso 1.0.0 on Solaris 9 Sparc
>> with Sun Studio 12 compiler and ran into a couple of portability issues:
> 
> Thanks for reporting them.
> I can test on Linux, FreeBSD and OpenSolaris 134. All on amd64 with gcc
> as compiler.
> 
> 
>> 1. Although configure already tests for the availability for stdint.h and
>> inttypes.h everywhere is unconditionally included stdint.h. 
>> 0001-Use-inttypes.h-when-stdint.h-is-not-available.patch
> 
>> +#ifdef HAVA_STDINT_H
>> #include <stdint.h>
>> +#else
> 
> I assume "HAVA" is a typo.
> At least i see on my Linux system only "HAVE_STDINT_H".
> So i will use the latter form.

Correct, due to lack of the first one I didn't notice :-)
It may be a good idea to have a general stdinclude.h or similar
which does the shielded includes.

>> 2. The function 'nanosleep' is in librt for Solaris 9.
> 
> There is only one occurence. Maybe i should use a less fancy way
> of waiting.
> Probably usleep(3) is the better choice. There are already lots of them
> in the code and you do not report problems with them.

Right, usleep is in the normal libc on Solaris and does not require
linkage to librt.

>> 3. The functions 'setenv' and 'unsetenv' are not available on Solaris 9
> 
> I wonder why my friend Vreixo used them in libisofs.
> The function in libisofs/util.c looks somewhat like a workaround
> for a missing system function.

You mean timegm?

>> http://www.gnu.org/software/hello/manual/gnulib/setenv.html
> 
> It would make my friends from FSF happy if i used gnulib. But i am reluctant
> to introduce such a dependency into the libburnia project. The fewer libs,
> the fewer problems. :))

gnulib is not a lib to depend on. It is a configure-time inclusion
from upstream gnulib git which is then statically includes the
substitute functions.

> I'll try to address all three stumblestones, upload a new 1.0.1 development
> snapshot tarball, and give you a note.

Cool :-) BTW, is it correct that 1.0.0 has this in configure.ac?

> BURN_MAJOR_VERSION=1
> BURN_MINOR_VERSION=0
> BURN_MICRO_VERSION=1

> -----------------------------------------------------------------------
> 
> I understand you can make xorriso-1.0.0 compile.

I could if the setenv-issue would have been taken care of
which I didn't fix for the moment. I'll check this after
the 1.0.1 build, ok?


Best regards

  -- Dago


> Does it operate your optical drives properly ?
> It should suffice to let it list the available drives:
> 
>  xorriso -devices
> 
> To be run as superuser or by help of pfexec (if available on Solaris 9).
> The result on my OpenSolaris looks like this
> 
>  Beginning to scan for devices ...
>  Full drive scan done
>  -----------------------------------------------------------------------------
>  0  -dev '/dev/rdsk/c2t2d0s2' r----- :  'TSSTcorp' 'CDDVDW SH-S223B' 
>  1  -dev '/dev/rdsk/c3t0d0s2' r----- :  'TSSTcorp' 'DVD-ROM SH-D162C' 
>  -----------------------------------------------------------------------------
> 
> If a drive is not listed then one would have to assume problems.
> In that case i could need extra verbous output:
> 
>  xorriso -scsi_log on -report_about DEBUG -devices >/tmp/xorriso_log 2>&1  
> 
> and, if possible, the output of
> 
>  cdrecord -scanbus
> 
> 
> Have a nice day :)
> 
> Thomas
>