[CASHeW-s-Editor] Re: [CASHeW-s-editor-patches] I am commiting changes tosupportconsistent behavour (starting from max always) of editor.......

[Ravish Bhagdev]

----- Original Message ----- 
From: "Barry Norton" <address@hidden>
To: "'CASHeW-s Editor Patches'" <address@hidden>
Sent: Thursday, March 31, 2005 2:09 PM
Subject: RE: [CASHeW-s-editor-patches] I am commiting changes 
tosupportconsistent behavour (starting from max always) of editor.......


> OK, now I'm more than a little annoyed - I didn't explain why I wanted
> the behaviour I did, nor why I wanted the code in the place I did,
> because I thought it would be enough that I had stated it as a
> requirement.
>
> If I have to be completely explicit to have something done the way I
> want then here goes:
>
> 3) I want the functionality that achieves all this in the factory
> because otherwise it is going to be massively duplicated (a common
> method in the future abstract ProcessFactory superclass should take care
> of this, not several separate functions in the parsing functionality).

This was done by Roger, and is using he factory, and he also squashed bugs 
in editing on model...

> 4) I don't want a static list of node names because (as I've now shown,
> despite repeated claims that this wasn't possible) it is possible to
> have two diagrams open for editing in the same Eclipse instantiation and
> this prevents having two nodes/processes with the same name *in the
> different diagrams*!

For achieving this, I have used the Singleton concept of java to make 
Diagram object accessible elsewhere.  This was really pain, because we can 
get hold of this only from commands.  So, each time command is called, it 
changes the diagram object in the singleton to refer to currently opened 
Diagram in Eclipse....Dont know if you will consider this a hack, but I 
toiled a lot to find another way and failed :-(

This

> In future if you're not sure whether something I've gone into details on
> is a requirement or just a suggestion, please ask before assuming the
> latter.
>
> Thanks to Ravish for implementing the functionality, once I explained
> the first two of these points, but if re-factoring is necessary to do it
> the way I said, please get that done immediately.
>
> And please sort out that final point before I see the editor again...
>
> Barry
>
>
>
>
>
>
> > -----Original Message-----
> > From:
> address@hidden
> > [mailto:cashew-s-editor-patches-
> > address@hidden On Behalf Of Andrew John
> > Hughes
> > Sent: Thursday, March 31, 2005 1:19 PM
> > To: CASHeW-s Editor Patches
> > Subject: Re: [CASHeW-s-editor-patches] I am commiting changes to
> > supportconsistent behavour (starting from max always) of editor.......
> >
> > On Thu, 2005-03-31 at 03:43 +0100, Ravish Bhagdev wrote:
> > > I am comming the attached patch to allow only nodes with maximum
> number
> > from the nodes always, as Barry suggested in last meeting.  Three
> model
> > files are modified as mentioned below (patch attached):
> > >
> > > Changelog:
> > >
> > > 2005-03-31  Ravish Bhagdev  address@hidden
> > >
> > > * src/nongnu/cashews/eclipse/model/Connection.java
> > > * src/nongnu/cashews/eclipse/model/DiagramParser.java
> > > * src/nongnu/cashews/eclipse/model/NodeRegistrar.java
> > >
> > > - getSource() method added in Connection class
> > > - Parser modified to remove a bug causing repetition of outgoing
> edges
> > in model.
> > > - Added private int max property in NodeRegistrar along with getter
> and
> > setter methods for the same.
> > >
> > > - Ravish.
> > > _______________________________________________
> > > CASHeW-s-editor-patches mailing list
> > > address@hidden
> > > http://lists.nongnu.org/mailman/listinfo/cashew-s-editor-patches
> > >
> > >
> > >
> > >
> > >
> ------------------------------------------------------------------------
> > --------
> > >
> > >
> > > _______________________________________________
> > > CASHeW-s-editor-patches mailing list
> > > address@hidden
> > > http://lists.nongnu.org/mailman/listinfo/cashew-s-editor-patches
> > > _______________________________________________
> > > CASHeW-s-editor-patches mailing list
> > > address@hidden
> > > http://lists.nongnu.org/mailman/listinfo/cashew-s-editor-patches
> >
> > I don't get why you create the Nodes manually in the Parser, rather
> than
> > using the factory, which already has a method for capturing the node
> > number.  It seems we have duplicate functionality here.
> >
> > Also, I don't know what went wrong with the patch, but it seems to
> > replace the entire parser, even though not all of it has changed.
> > --
> > Andrew :-)
> >
> > Please avoid sending me Microsoft Office (e.g. Word, PowerPoint)
> > attachments.
> > See http://www.fsf.org/philosophy/no-word-attachments.html
> >
> > No software patents in Europe -- http://nosoftwarepatents.com
> >
> > "Value your freedom, or you will lose it, teaches history.
> > `Don't bother us with politics' respond those who don't want to
> learn."
> > -- Richard Stallman
> >
> > Escape the Java Trap with GNU Classpath!
> > http://www.gnu.org/philosophy/java-trap.html
> > public class gcj extends Freedom implements Java { ... }
>
>
>
>
> _______________________________________________
> CASHeW-s-editor-patches mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/cashew-s-editor-patches