Re: [Chicken-hackers] [PATCH][5] FQN woes

[Evan Hanson]

Hey Lemonboy,

On 2017-05-09 16:20, lemonboy wrote:
> since both `##sys#macro-environment` and `##sys#current-environment`
> are alists whose keys are unqualified symbol names it doesn't make
> sense to use `var` as lookup key since after the initial lookup of
> `var0` against the environment we possibly get back a fully-qualified
> symbol thus making the lookup fail.

Good catch, thanks.

Just repeating what I said on IRC: could you add a small test that
checks for one of each of these warnings? There are already some tests
that check the compiler's output, and even just adding the example you
gave to one of those would be fine.

> I don't know if the same treatment should be applied to the `keyword?`
> test below, if it can be folded inside the `cond`

Keywords are never bound in the environment so it doesn't matter, but if
you want to use the same variable as is used in the other checks for
consistency's sake, that makes sense to me. Pulling it up makes sense
too.

Cheers,

Evan