Re: [Chicken-hackers] [PATCH 0/4] Some symbol and module-related patches

[Peter Bex]

On Sat, May 13, 2017 at 07:55:44PM +1200, Evan Hanson wrote:
> The first changes the way explicitly-namespaced symbols are handled
> (that is, symbols with a module name directly included, like "foo#bar"),
> making them behave essentially like qualified symbols as far as variable
> resolution is concerned. This allows them to be used across module
> boundaries, granting us more freedom to organise things in the way that
> makes most sense within core. Please see the commit message for full
> details.

Two quick questions: Given that C_namespaced_symbolp is inlineable and
unsafe, shouldn't it be named C_u_i_namespaced_symbolp?

And, given that it's inlineable, I think it would be better to put it in
tweaks.scm (for example) as a define-inline.  I think this would be much
more efficient.  Perhaps this even dwarfs the scan time of memchr.

Other than that, to me this looks like a very nice set of patches and it
should definitely make it easier for us to move stuff around now.
Great work!

Cheers,
Peter

signature.asc
Description: Digital signature