Re: [Chicken-hackers] [PATCH] Fix for Windows quoting issues (fixes #1515)

[Peter Bex]

On Sat, Sep 01, 2018 at 10:09:00PM +0200, address@hidden wrote:
> > Here's a patch for #1515.  It turns out to be quite invasive because the
> > quotation stuff was completely messed up.  Even on *nix, chicken-install
> > didn't work when CHICKEN was installed to a PREFIX path with spaces in it!
> >
> 
> I maybe missing something, but why is "slashify" not used anymore?

I thought it wasn't necessary anymore, but on second thought that might
have been a mistake: qs doesn't convert to slashes.  Having said that,
it looks like slashify was used just as inconsistently as quotearg.

If you follow the instructions in the README, you need to install with
a PREFIX that uses slashes rather than backslashes; I did not experience
any problems when I tested this code.

I don't know how to easily test whether it's working, but I have a
feeling it *can't* work because the majority of paths aren't actually
slashified (unless I'm overlooking something).

Maybe to keep things simple we can leave it out.  If you can explain what
one should do to trigger issues caused by missing slashify, I wouldn't
mind reworking the patch to add slashify calls whereever it is necessary.

Cheers,
Peter

signature.asc
Description: PGP signature