Re: [Classpath-inetlib] Problems in gnu.inet.util.LineInputStream and gnu.inet.util.CRLFInputStream

[Chris Burdess]

Robert Mitchell wrote:
> One way around the problems with mbox, etc. is to filter them to add 
> the CR to the end of line sequence.

That's true, although our recent discussion shows some of the inherent 
difficulties and inefficiencies processing multi-character delimiters, 
therefore I feel that normalisation to a single delimiter prior to 
processing should yield better results.

> All that aside, I do not think it would be worth changing the 
> architecture unless the current implementation is considered 
> incompatible with the JavaMail specification.  I think this is an area 
> where the specification is incomplete, although you might argue that 
> the references to the Internet mail RFC's requires CRLF endings for 
> javax.mail.internet implementations at a minimum.

That should be the case for e.g. InternetHeaders parsing: if there are 
other cases where CRLFs are not normalised, please let us know.

I have submitted a new version of CRLFInputStream now, and tested it 
with the special case where the first CR is at the end of the buffer. 
This doesn't seem to result in a significant performance change from 
the previous version in my tests, if you have different results I'd be 
interested in seeing them.
--
Chris Burdess